GODRIVER-2972 Fix wiremessage RequestID race in operation.Execute #1375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prestonvasquez
requested review from
qingyang-hu
and removed request for
a team
prestonvasquez
had a problem deploying
to
api-report
GitHub Actions
Failure
matthewdale
approved these changes
Sep 6, 2023
| @@ -1120,7 +1125,7 @@ func (op Operation) createMsgWireMessage(ctx context.Context, maxTimeMS uint64, | |||
| flags |= wiremessage.ExhaustAllowed | |||
| } | |||
|
|
|||
| info.requestID = wiremessage.CurrentRequestID() | |||
There was a problem hiding this comment.
Optional: Are any uses of CurrentRequestID safe? Should we remove that function completely and only call NextRequestID?
There was a problem hiding this comment.
Good Idea, I would guess not since the requestID is a global variable. Done.
prestonvasquez
temporarily deployed
to
api-report
GitHub Actions
Inactive
API Change Report./x/mongo/driver/wiremessageincompatible changesCurrentRequestID: removed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GODRIVER-2972
Summary
The usage of "wiremessage.CurrentRequestID()" in the operation.Execute method will cause a race condition where concurrent calls to Execute will result in wire messages from different operations sending the same RequestID to the server.
Background & Motivation
NA